Interested in an upgrade

[RAYBRO62]

I'd like to upgrade by iPhone XS to an 11.  And my daughter iphone 8+ to iPhoneXR.  I'd like to do it via the computer as to not have the activation fee.

#1- what's a better phone 11, 11 Pro Max. I take alot of photos

#2-  Can we trade in our old phones to get a credit for the new ones?

I didn't want to go into a store unless I have to.

Thank you.