how do I back up my pictures from iPhone 4s so when I upgrade my phone I don't lose them?
Four simple ways to back up your iPhone photos
For Seniors: Back Up Your iPhone 4S to iCloud - For Dummies
Import photos and videos from your iPhone, iPad, or iPod touch to your Mac or Windows PC - Apple Support
As you can see there are many ways.
Good Luck